Make sure we dispose CancellationTokenRegistration #2776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
force-pushed
the
fix/dispose-cancellation-token-registration
branch
from
85802bf to
d66138b
Compare
russcam
approved these changes
Jun 19, 2017
|
|
||
| if (data != null) | ||
| var request = this.CreateHttpWebRequest(requestData); | ||
| using (cancellationToken.Register(() => request.Abort())) |
There was a problem hiding this comment.
Does this also need to include await GetResponseAsync(requestData, request, builder); in the using block?
There was a problem hiding this comment.
You're right i think it does
|
@forloop updated with one more commit mind giving this another review? 👍 |
… single request, e.g bulkall/scrollall/reindex it will leak Register() handles and memory will keep on growing
…ely cancel on the waithandles in the case of exceptions too
Mpdreamz
force-pushed
the
fix/dispose-cancellation-token-registration
branch
from
47afefc to
fd2cc93
Compare
Mpdreamz
added a commit
that referenced
this pull request
Jun 21, 2017
* When the passed cancellation token is shared for a longer time then a single request, e.g bulkall/scrollall/reindex it will leak Register() handles and memory will keep on growing * PostRequestAsync does not need to be generic * include GetResponse() in using and inlined it so we can more aggresively cancel on the waithandles in the case of exceptions too
Mpdreamz
added a commit
that referenced
this pull request
Jun 21, 2017
…hat now needs forward porting again to 5.x master cc @russcam
Mpdreamz
added a commit
that referenced
this pull request
Jun 21, 2017
…e begin/end getrequeststream apm task wait handler relates to #2776
Mpdreamz
added a commit
that referenced
this pull request
Jun 21, 2017
…e begin/end getrequeststream apm task wait handler relates to #2776
|
@russcam spotted an opportunity to clean up the code while manually merging to |
|
Nice! |
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
* When the passed cancellation token is shared for a longer time then a single request, e.g bulkall/scrollall/reindex it will leak Register() handles and memory will keep on growing * PostRequestAsync does not need to be generic * include GetResponse() in using and inlined it so we can more aggresively cancel on the waithandles in the case of exceptions too
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
…e begin/end getrequeststream apm task wait handler relates to elastic#2776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the passed cancellation token is shared for a longer time then a single request, e.g bulkall/scrollall/reindex all spawn multiple requests over a single cancellationtoken it will leak Register() handles and memory will keep on growing because it will keep
requestsaround indefinitely.